Open Sertzu opened 5 months ago
Thanks for your pull request, we appreciate your feedback and input. We will merge it by adding a customizable define to declare a specific calling convention. This way the calling convention can be set by a cmake flag, if required.
Calling conventions depend on the system; different architectures use different defaults. Calling conventions can be e.g.:
We will therefore introduce a define (cmake flag), which can be overwritten if needed.
This is a proposed solution to issue #310
Changing the calling convention from stdcall to cdecl here enables the library to operate in 32-bit mode. Since the .dll is also compiled with __cdecl as the calling convention this makes sense.
However, we weren't able to test if the library still works fine with real hardware though.