fixed some things to get this going in our environment

SIDN / CycleHunter

Python software that reads zone files, extract NS records, and detect cyclic dependencies

https://tsuname.io

BSD 2-Clause "Simplified" License

37 stars 14 forks source link

fixed some things to get this going in our environment #5

Closed dirkvdplas closed 3 years ago

dirkvdplas commented 3 years ago

zoneMatcher.py

regex for definining NS records is better
conditional under 'if not foundZone:' is wrong
fulldepparser.py: split() is better because split('\n') is too restrictive

gmmoura commented 3 years ago

I tested in my env and I could not parse my files; so I fixed it again, see if it works on your env. (then I can accept the PR)

gmmoura commented 3 years ago

I've updated the main branch to detect if a file is tab or space separated. could you please test on your env?

also, can you please submit the changes you did on zoneMatcher.py on https://github.com/SIDN/CycleHunter/pull/5/commits/aba530eadfb11d4d980f56bb0dc0a72cf5bfca5a as a separated PR, so I can accept it? thanks @dirkvdplas