search

SIMEXP / wrangling-phenotype

get ukbb data in shape for other projects
MIT License
0 stars 0 forks source link

Added cobre script #4

Closed clarkenj closed 8 months ago

clarkenj commented 8 months ago

@htwangtw I have made age of type float, do you think this is best or should we use integer?

htwangtw commented 8 months ago

I feel this is going to vary by data set a bit - I would rather save it as float just in case we encounter dataset with age as a float. From what I know NKI does have age in float

clarkenj commented 8 months ago

Ok cool, that was my thinking too! It is an integer for cobre.

clarkenj commented 8 months ago

@htwangtw I'd appreciate your review again :) For the male/female I made all lower case, I don't know if it matters too much but it would be nice to be consistent?

clarkenj commented 8 months ago

@htwangtw I pushed some more changes, another round of review would be great I think, thank you!