search

SIMPLE-AstroDB / SIMPLE-db

BSD 3-Clause "New" or "Revised" License
11 stars 22 forks source link

Ingesting spectra for Manj16 #226

Closed SherelynA closed 2 years ago

kelle commented 2 years ago

Xshooter has only one mode so providing a mode isn't necessary.

SherelynA commented 2 years ago

Everything seems to looks good and ready to merge

SherelynA commented 2 years ago

This looks great! Only thing which we should do is to add a new data test for the em.IR.NIR and em.opt regimes.

On lines 243-249 of test_data.py there are tests for nir and optical. Can you use those a guide to add two new tests for em.IR.NIR and em.opt regimes?

I added the two new test that check for those two regimes.

kelle commented 2 years ago

This looks perfect -- great work!