search

SIMPLE-AstroDB / SIMPLE-db

BSD 3-Clause "New" or "Revised" License
11 stars 22 forks source link

Units are resolvable by astropy #325

Closed dr-rodriguez closed 1 year ago

dr-rodriguez commented 1 year ago

We want units in the Modeled Parameters table to be resolvable by the astropy.units module.

Ajb2307 commented 1 year ago

Hi, I want to start working on this. I see it's labeled as tests. Is that where you want to script for this?

kelle commented 1 year ago

The test should go in the tests/test_integrity.py module. It should actually be very similar to the test already in test_spectra function starting on line 469 of that file. You can use that as a guide to help get started.

One challenge is that there is no data in the modeled parameters table yet so it will be hard to see if the test is working but I'm all in favor of having the test in place before we start adding data!

Ajb2307 commented 1 year ago

Im going to ingest test parameters from Table 9 of Filippazzo https://ui.adsabs.harvard.edu/abs/2015ApJ...810..158F/abstract To test code I've written