Making astropy units resolvable on modeled parameters

SIMPLE-AstroDB / SIMPLE-db

BSD 3-Clause "New" or "Revised" License

11 stars 22 forks source link

Making astropy units resolvable on modeled parameters #340

Closed Ajb2307 closed 1 year ago

Ajb2307 commented 1 year ago

Closes Issue #325

[x] Creating code to test units that will go into modeled parameters
[x] Will test with an ingest from https://iopscience.iop.org/article/10.1088/0004-637X/810/2/158#apj518886t9 table 9
[x] Test incorrectly formatted data mark as expected fails

kelle commented 1 year ago

Great progress -- Awesome that all of those units are resolvable!

Next step would be to add some data which have incorrectly formatted units. Maybe try "Kelvins" and "M_jupiter". Make some tests which fail and then on Friday we'll discuss how to mark them as "expected" to fail.