Rework photometry filters

SIMPLE-AstroDB / SIMPLE-db

BSD 3-Clause "New" or "Revised" License

11 stars 22 forks source link

Rework photometry filters #379

Closed dr-rodriguez closed 1 year ago

dr-rodriguez commented 1 year ago

This updates the Photometry and PhotometryFilters table in various ways:

UCD column moved from Photometry to PhotometryFilters
instrument and telescope columns removed from PhotometryFilters
Foreign Key of Photometry reworked to point to Telescopes
instrument column removed from Photometry (in anticipation of #380)

Closes #293

kelle commented 1 year ago

This looks good but I admit to not having my head fully wrapped around it. Should we write some tests to go along with it?

dr-rodriguez commented 1 year ago

We have tests that query Photometry and PhotometryFilters already, I'm not sure what else we would add to them. The database will not build if the foreign keys and similar are not set.

I did notice the tests failing with the Instruments change (#380), but that's a separate PR.

kelle commented 1 year ago

This change will break the ingest_photometry function. The tests still pass because there are currently no tests for that function. I will open an issue to write tests and modify the ingest_photometry function accordingly.