SIMPLE-AstroDB / SIMPLE-db

BSD 3-Clause "New" or "Revised" License
11 stars 22 forks source link

Reorganize scripts into new package #457

Closed kelle closed 8 months ago

kelle commented 8 months ago

Link to relevant issue: Closes #456 and #372

Will-Cooper commented 8 months ago

minor thing to update import group order to be external libraries > standard libraries > local libraries, so plotting_example would become

from astrodbkit2.spectra import load_spectrum
import astropy.units as u
import matplotlib.pyplot as plt
import numpy as np
from sqlalchemy import and_, cast, func, Integer

import logging

from scripts.ingests.ingest_utils import convert_spt_code_to_string_to_code
from scripts.ingests.utils import load_simpledb, logger
from scripts.ingests.simple_utils import convert_spt_code_to_string_to_code
kelle commented 8 months ago

I appreciate this comment, but I don't think it's high priority to do that type of cleaning on the example scripts in this repo. The examples that end up in the template repo, on the other hand, should be as perfect as possible.