JWST spectra ingest, spectra utils improvements - Githubissues

SIMPLE-AstroDB / SIMPLE-db

BSD 3-Clause "New" or "Revised" License

11 stars 21 forks source link

JWST spectra ingest, spectra utils improvements #458

Closed kelle closed 5 months ago

kelle commented 6 months ago

Ingesting one JWST T dwarf spectrum. Also working on improving spectra ingest scripts and modifying given new astrodb_scripts package.

For data ingests:

[x] includes script used for ingest.
[x] includes modified JSON files
[x] Add new tests
[x] Update the Versions table

kelle commented 5 months ago

Apologies, this is really two different things.

the reorg of the ingest scripts used for spectra. these are mostly directory name and file name changes. Also removed functions which are now in the astrodb_scripts package
an ingest of one new spectrum. @SherelynA , check out the updated JSON file for W1935.

kelle commented 5 months ago

I guess I could add some tests for ingest_spectrum function...

SherelynA commented 5 months ago

@kelle do you also plan to ingest the MIRI JWST photometry?

kelle commented 5 months ago

I do not have those data. If you want to post here, I'll give it a go at ingesting.

SherelynA commented 5 months ago

I do not have those data. If you want to post here, I'll give it a go at ingesting.

@kelle This is the data: We used the following filters and the magnitudes/uncertainties (aper_total_vegamag) used :MIRI.F1000W - (13.740374118847015, 0.00509224851727859) & MIRI.F1280W - (13.125575556995827, 0.00711303904668107) & MIRI.F1800W - (12.108791667404923, 0.01817644357837899)

kelle commented 5 months ago

I assume those are JY, right? And any reason to maintain all those significant figures?

kelle commented 5 months ago

Photometry (and tests) added
more ingest script work

kelle commented 5 months ago

This could be reviewed and merged at any point. I'm just gonna keep polishing the new scripts and tests until it's merged. :)

SherelynA commented 5 months ago

I assume those are JY, right? And any reason to maintain all those significant figures?

@kelle I don't know if I understand this well. I gave the magnitudes, not the fluxes which like you mentioned are in Janskys.

kelle commented 5 months ago

Yes, I reminded myself about magnitudes being flux ratios after posting that comment. I rounded the numbers based on the uncertainties. What numbers are reported in the paper?

SherelynA commented 5 months ago

Yes, I reminded myself about magnitudes being flux ratios after posting that comment. I rounded the numbers based on the uncertainties. What numbers are reported in the paper?

@kelle The numbers reported in the paper are the following F1000W: (13.740±0.005) & F1280W: (13.126±0.007) & F1800W: (12.107±0.017).