search

SIMPLE-AstroDB / SIMPLE-db

BSD 3-Clause "New" or "Revised" License
11 stars 21 forks source link

Add ingest_radial_velocity function. #475

Closed kelle closed 3 months ago

kelle commented 5 months ago

Utility function and test to ingest radial velocities.

kelle commented 5 months ago

The ingest_gaiadr3 script was just copied and pasted from a stale PR. It's in the scripts/ directory, not the utils directory. I think it can receive more time and attention once it's actually used as part of an ingest. But right now, I just didn't want to lose the work. So, long story short, I don't want to spend time tidying that script.

The function worthy of more scrutiny is the ingest_radial_velocity function in the astrometry module.

kelle commented 5 months ago

I will add type hints to the ingest_radial_velocity function and something about units.

Also, since there is not yet any rv data in SIMPLE, I will also modify the schema to add units to the column names.

kelle commented 5 months ago

Because I've improved the testing setup in #471, I should really wait for it to be merged before progressing with this one.