fix generate_database action

SIMPLE-AstroDB / SIMPLE-db

BSD 3-Clause "New" or "Revised" License

11 stars 21 forks source link

fix generate_database action #479

Closed kelle closed 3 months ago

kelle commented 4 months ago

Re-adds the generate_database.py script to generate the database file for the SIMPLE-binary repo.
Changed database name from .db to .sqlite.

kelle commented 4 months ago

Getting a username/password error. Not sure if that's because this is a pull requests or not.

dr-rodriguez commented 3 months ago

Getting a username/password error. Not sure if that's because this is a pull requests or not.

Likely yes, I think there are secrets either in this repo or in the binary repo that control how we can push to the binary repo. I don't know if pull requests can access this information.

dr-rodriguez commented 3 months ago

Recommend avoiding load_astrodb for now, as that re-defines reference tables and such. It's best to have lower-level functions here (ie, direct calls to astrodbkit2) rather than this wrapper.

kelle commented 3 months ago

Recommend avoiding load_astrodb for now, as that re-defines reference tables and such. It's best to have lower-level functions here (ie, direct calls to astrodbkit2) rather than this wrapper.

I disagree. This is exactly the use case for load_astrodb and I'd rather just fix it at the source. This PR is back in Draft mode while I make the needed changes in astrodb_utils.

kelle commented 3 months ago

Waiting on https://github.com/astrodbtoolkit/astrodb_utils/pull/42