search

SIMPLE-AstroDB / SIMPLE-db

BSD 3-Clause "New" or "Revised" License
11 stars 21 forks source link

Rename spectrum to access_url #494

Closed dr-rodriguez closed 2 months ago

dr-rodriguez commented 2 months ago

Short description:
Rename the spectrum column to access_url in the Spectra table

Link to relevant issue: Closes #477

For data ingests: [X] includes script used for ingest [X] includes modified JSON files [X] Add/update tests [X] Update the Versions table

dr-rodriguez commented 2 months ago

Do we want/need an entry in Versions as described in the template?

dr-rodriguez commented 2 months ago

Also, I did notice the re-ordering of a handful of SpectralTypes entries. Not sure how to resolve that yet, but maybe this PR will sync them to their proper order?

kelle commented 2 months ago

Also, I did notice the re-ordering of a handful of SpectralTypes entries. Not sure how to resolve that yet, but maybe this PR will sync them to their proper order?

I'm happy to do that here since so many files are being touched anyway. If it happens again, however, we should open an issue and see if we can prescribe the order.

kelle commented 2 months ago

Do we want/need an entry in Versions as described in the template?

I vote yes, I think this change warrants a release and a version increment. We'll need to be careful implementing on the website because this change may break the web app.

dr-rodriguez commented 2 months ago

Updated scheduled_checks and added an entry to Versions (2024.4). These are now the versions we have:

version start_date  end_date                    description                  
------- ---------- ---------- -----------------------------------------------
 2022.1 2020-06-22 2022-08-23                                 Initial release
 2022.2 2022-08-23 2022-10-11                                            None
 2022.3 2022-10-11 2022-10-13                            Added VHS 1256b data
 2022.4 2022-10-14 2022-10-16                                                
 2022.5 2022-10-16 2022-12-28 Adds T and Y dwarfs from Leggett 21 compilation
 2023.1 2022-12-28 2023-07-11                                   Schema rework
 2023.2 2023-07-11 2023-07-25                Added JWST spectra for VHS 1256b
 2023.3 2023-07-25 2023-10-18             Companions table, fixed IRS spectra
 2023.4 2023-10-18 2023-12-12                               Added two sources
 2023.5 2023-12-12 2023-12-29     Included Roth sources, fixed Bard14 spectra
 2024.1 2023-12-29 2024-02-15          Added JWST spectrum for WISE 1935-1546
 2024.2 2024-02-15 2024-03-05                                  Regime cleanup
 2024.3 2024-03-05 2024-04-17                 UCDs in PhotometryFilters table
 2024.4 2024-04-17 2024-04-19 Renaming Spectra.spectrum to Spectra.access_url
 latest 2024-04-19       None                          Version in development
dr-rodriguez commented 2 months ago

I'll hold off on merging until next week, just in case we want to do the explicit release then (which as you say would break the website). Better to do it when we have time to address it quickly then.