Reworking how ingest_spectrum works using the ORM

SIMPLE-AstroDB / SIMPLE-db

BSD 3-Clause "New" or "Revised" License

11 stars 21 forks source link

Reworking how ingest_spectrum works using the ORM #501

Open dr-rodriguez opened 1 month ago

dr-rodriguez commented 1 month ago

First pass at reworking how ingest_spectrum works using the ORM

Separate PR from https://github.com/kelle/SIMPLE-db/pull/4 to either merge separately and/or have the automated tests run.

kelle commented 1 week ago

return a dictionary called flags.

"added": True if it's added and False if it's skipped.
"content": the data that was attempted to add
"message": string which includes information about why skipped

dr-rodriguez commented 21 hours ago

I've added the return of flags and significantly cleaned up the tests. However, I just realized that things like telescope, instrument, and mode used to be checked so we should update the validation to ensure they are present.