ingest radial velocities from the Ultracool sheet

SIMPLE-AstroDB / SIMPLE-db

BSD 3-Clause "New" or "Revised" License

11 stars 21 forks source link

ingest radial velocities from the Ultracool sheet #511

Closed Exu-112 closed 1 week ago

Exu-112 commented 3 weeks ago

Short description: Ingesting radial velocities from the Ultracool sheet

Link to relevant issue: Closes #506

For data ingests:

[x] includes script used for ingest
[x] includes modified JSON files
[x] Add new tests
[x] Update the Versions table

Exu-112 commented 3 weeks ago

@dr-rodriguez tests pass locally, please review script before I upload json files

dr-rodriguez commented 3 weeks ago

I think the script and test looks good. I added a few minor comments. In general, I think some formatting could help readability- more spaces or line breaks. But that's something an autoformatter like ruff/black/darker can take care of.

For now, I think this is good and you can generate and add the JSON files and update the Versions table.

kelle commented 2 weeks ago

I am ok with not updating the versions table for this PR since 1) I'm at a conference this week and 2) We've got the Spitzer photometry ingest hot on the heels of this ingest.