search

SINTEF-9012 / kafka-mqtt-sink-connector

A connector plugin to use with Kafka's Connect API. It contains functionality to extract a topic from the Kafka record and publish to that topic on the mqtt broker, if dynamic publishing is required. The connector can be configured to use SSL in communication with the mqtt broker.
MIT License
9 stars 3 forks source link

Some minor issues with some text in the EADME.md #2

Closed nguyenhongphu closed 4 years ago

nguyenhongphu commented 4 years ago

There are some copy and paste issues. Maybe you forgot to change the corresponding text for the sink connector :)

For example: "Connect in general Build this java maven project, but navigating to root kafka-mqtt-source-connector in a terminal and typing:" "root kafka-mqtt-source-connector" should be kafka-mqtt-sink-connector

"Copy the kafka-mqtt-source-connector-"version".jar" should be "Copy the kafka-mqtt-sink-connector-"version".jar" ?

Steps 5 and 6 should start from new lines.

In Step 7. Start our connector by posting the following command to the Connect REST-interface: curl -s -X POST -H 'Content-Type: application/json' http://127.0.0.1:19005/connectors -d '{"name":"mqtt-sink-connector","config":{"connector.class":"com.sintef.asam.MqttSinkConnector","tasks.max":"1","mqtt.connector.broker.uri":"tcp://localhost:1883", "mqtt.connector.broker.topics.regex":"test*","mqtt.connector.mqtt_topic_key":"topic"}}'

I got an error if using "mqtt.connector.broker.topics.regex". Should it be without "mqtt.connector.broker." ?

curl -s -X POST -H 'Content-Type: application/json' http://127.0.0.1:19005/connectors -d '{"name":"mqtt-sink-connector3","config":{"connector.class":"com.sintef.asam.MqttSinkConnector","tasks.max":"1","mqtt.connector.broker.uri":"tcp://localhost:1883", "topics":"test","mqtt.connector.mqtt_topic_key":"topic"}}'

brice-morin commented 4 years ago

Hi Phu, I confirm those issues. You've now been invited to SINTEF-9012 so that it will be more efficient to fix small issues than to report them :-)

nguyenhongphu commented 4 years ago

Many thanks :-)