Closed jesper-friis closed 2 months ago
Where is the change in the github workflows?
The failing tests were not run on GitHub CI. The wheel tests only runs a subset of the python tests. This should be fixed when the issue in tripper has been fixed. Should we do that in a new PR?
TODO: Run all tests when building wheels, nut just a selection of the python tests
Description
Fix failing tests on manylinux2014_i686.
Motivation: Fix the segfault we get on github for Python 3.12 on manylinux2014_i686. Unfortunately, I wasn't able to reproduce the segfault when running the docker locally.
While debugging, some issues related compiling on a 32 bit platform were revealed. These are fixed in this PR.
Fixes and changes in this PR:
Unsolved issues:
python bindings/python/tests/test_python_bindings.py
. Ideally we would like to run all tests usingctest
, but that seems difficult to do... The reason is thatctest
must be run from the build directory, but the wheel tests are defined bytest-command
inpython/pyproject.toml
. As far as I can see, there is no way to get the build directory frompyproject.toml
.Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.