search

SINTEF / olmo

SINTEF OceanLab Observatory data handling and storage
3 stars 4 forks source link

shorter inits of sensor classes #88

Closed WillRNaylor closed 1 year ago

WillRNaylor commented 1 year ago

Hey,

This PR is close to 100% cosmetic if I didn't stuff anything up. The one actual change is that the default value of "remove_remote_files_lX" has been changed from "True" to "False", as that seemed a little safer.

I am mostly putting you as reviewers so you can comment if you want, or simply so you know this change has happened.

Finally, this changes core code in a number of placs, so although I've tested it on on the munkholmen_pi_status and standard munkholmen ingests (it worked), I think I'll have to just test this branch it on main pipeline (user oceanlab on torfinn2) probably tomorrow morning and monitor that nothing goes wrong before merging.

emlynjdavies commented 1 year ago

i have not tested either, but i think this is a good improvement