search

SINTEF / soft7

SINTEF Open Framework and Tools for Data Driven Semantic Interoperability
https://sintef.github.io/soft7
MIT License
4 stars 0 forks source link

Update pre-commit hooks #14

Closed CasperWA closed 1 year ago

CasperWA commented 1 year ago

Update the existing pre-commit hook versions.

Also, update codebase according to a run with the new versions. Some issues were found with mypy and pydantic concerning the create_model() function, which doesn't seem to be registerring correctly in mypy. Either that or I missed something crucial.

The use of lambda functions should be reevaluated as well (new issue opened #15).

CasperWA commented 1 year ago

Can you just double-check if the expression if not Path(data_model).resolve().exists: is actually wrong?

It is, exists is a method (callable), not a property apparently :/ Python docs.