search

SINTEF / soft7

SINTEF Open Framework and Tools for Data Driven Semantic Interoperability
https://sintef.github.io/soft7
MIT License
4 stars 0 forks source link

Unit tests #17

Closed CasperWA closed 2 months ago

CasperWA commented 1 year ago

Closes #11 Closes #2

Add unit tests using the pytest framework.

The tests are run through a new CI job, which also uploads a code coverage report to codecov.io, see app.codecov.io/gh/SINTEF/soft7.

As a minimum, before making this PR ready for review, I want some basic unit tests for:

When tests for dataspace_factory.py have been put in place, issue #15 can be addressed, and it should be immediately apparent if any changes introduce a degradation of the expected behaviour.

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@84d8437). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage        ?   16.02%           
=======================================
  Files           ?       12           
  Lines           ?      387           
  Branches        ?        0           
=======================================
  Hits            ?       62           
  Misses          ?      325           
  Partials        ?        0
Flag Coverage Δ
pytest 16.02% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

CasperWA commented 11 months ago

The work on this has opened my eyes to the fact that the various parts of this repository really should be looked at again, possibly with a new approach to what it should actually contain - and do.

CasperWA commented 2 months ago

Closing as these changes are either already implemented through other PRs or are outdated.