SINTEFMedtek / CustusX

Research Platform for Image-Guided Therapy
http://www.custusx.org
Other
61 stars 25 forks source link

PNN reconstruction algorithm #36

Open Nicolaas94 opened 1 year ago

Nicolaas94 commented 1 year ago

Dear SINTEF developers,

In the documentation of the PNN algorithm, the following is written down: "If the voxel already has a value, different approaches are possible: Taking the average, taking the maximum, taking the most recent value, or taking the first value."

However, in CustusX 18.04 in the tab Acquisition>Reconstruction I can select the algorithm "pnn" but there is no option between the different approaches as stated in the documentation. I found in this GitHub that the algorithm used the maximum value as default, but I could not recognize any code for selecting an approach.

Is there a bug in my CustusX 18.04 or am I missing something?

olevs commented 1 year ago

Thank you for bringing this to our attention. This is indeed an error in the documentation.

Some code changes in PNNReconstructionMethodService::fillHole would be needed in order to try out some of the other possibilities.

Best Regards, Ole Vegard Solberg