search

SIPp / pysipp

SIPp for Humans - launch multiple agents with Python
GNU General Public License v2.0
179 stars 55 forks source link

Add test for proxy_host/proxy_port bug #64

Closed kontsaki closed 3 years ago

kontsaki commented 3 years ago

Hello, This test demonstrates how when using proxy_host without also settings proxy_port can lead to a bug cause of a missing space character at end of "-rsa" in command sipp_spec. For example if only remote_host is set to some address '10.0.3.27' then sipp reports: "Unknown remote host '10.0.3.27-sf'"

what should the approach be on solving this ?

kontsaki commented 3 years ago

uh, editor auto formatted with black.. the actual changed test is https://github.com/SIPp/pysipp/pull/64/files#diff-5592e672cef095f585fc0083c44cdfb8aafdfc11904a484dfa2b0794b0079f35R102 which is the last on test on test_commands that did not isolate between different assertions i use pytest.mark.parametrize to make the bug blow up

kontsaki commented 3 years ago

i will leave this here as well in case someone wants to fix this