SIPp / pysipp

SIPp for Humans - launch multiple agents with Python
GNU General Public License v2.0
179 stars 55 forks source link

`pysipp.server()` accepts `destaddr` as a keyword argument #80

Open BVollmerhaus opened 2 years ago

BVollmerhaus commented 2 years ago

pysipp.server() and pysipp.client() appear to be implemented identically, the only exceptions being their respective default scenario name and the fact that pysipp.server() is not supposed to accept a destaddr keyword argument. However, the guard inside the function checks for dstaddr (without the "e"), which I'd assume to be a typo. Since server and client can be used interchangeably, I don't think this has functional implications, though.

goodboy commented 1 year ago

@BVollmerhaus please feel free to write a test or example showing your concern more explicitly.

Ideally provide a test demonstrating the typo causing an issue and then provide the fix.