SIPp / pysipp

SIPp for Humans - launch multiple agents with Python
GNU General Public License v2.0
179 stars 55 forks source link

`trio` subprocs launching #87

Open goodboy opened 1 year ago

goodboy commented 1 year ago

Replacement for #55 after going through the slew of merge conflicts.

From that issue verbatim here is the original description:

ping @linuxmaniac


This is in preparation of a python 3.6+ only 1.0.0.alpha release and replaces all the internal processing launching machinery with the new subprocess support in trio.

This not only gets us cross OS support for free but also gives access to async/await based scenario and agent spawning.

A few interesting notes:

TODO:

I look forward to feedback and thoughts!

goodboy commented 1 year ago

Looks like I've broken something using the new spawn api, not sure what.

I don't have the sipp binary installed locally atm so if someone wants to take a shot at repairing this (hint hint @linuxmaniac) please feel free!

linuxmaniac commented 1 year ago

BTW, some of the commits don't pass the pre-commit checks.

when rebasing, you should do git rebase -x 'pre-commit run --from HEAD^ --to HEAD' origin/master in order to force the execution of pre-commit checks per commit

goodboy commented 1 year ago

@linuxmaniac RE all the little changes you suggest, can you make a PR onto this branch to fix them if you've already gone through it?

linuxmaniac commented 1 year ago

@linuxmaniac RE all the little changes you suggest, can you make a PR onto this branch to fix them if you've already gone through it?

There you are https://github.com/SIPp/pysipp/pull/88

goodboy commented 1 year ago

@linuxmaniac landed it 🏄🏼

goodboy commented 1 year ago

There rebased clean to master.