search

SIPp / sipp

The SIPp testing tool
https://sipp.readthedocs.io
Other
918 stars 380 forks source link

CMake: Increase minimum version to 3.5 #649

Closed orgads closed 8 months ago

orgads commented 1 year ago

CMake is about to drop support for earlier versions.

lemenkov commented 8 months ago

I don't see any issues however my opinion you should elaborate why this change is beneficial for SIPp. At least it could cmplicate SIPp build process on some (unknown to me) old platforms.

lemenkov commented 8 months ago

Ok I looked at a similar proposal and it looks like we can do it quite safely. As a bonus we now can officially use generator expressions within INSTALL directive. I thing we can try raise it a bit more since as someone in another issue stated ann CMake versions higher than 3.5 have a better CXX11 support.