Closed IvanRibakov closed 8 months ago
LGTM
@wdoekes Any chance this can make it into the next patch release?
I think it looks good.
No sudden camelCase please though: gotCAFile
And not sure why the "\n" in the WARNING.
Right now I count:
$ wgrep . 'WARNING("[^"]*[^n]",' | wc -l
87
87 WARNINGs without LF and
$ wgrep . 'WARNING("[^"]*[n]",' | wc -l
5
5 ones with.
Are all the other WARNINGs without LF bad?
No sudden camelCase please though: gotCAFile
My bad, will fix!
Are all the other WARNINGs without LF bad?
Yes, they cause log messages to concatenate in one long line.
Yes, they cause log messages to concatenate in one long line.
Fair enough.
Thanks! :+1:
Currently CRL file specified via
tls_crl_name
flag is being loaded even if it wasn't supplied, causing TLS initialisation to fail:This PR ensures that custom behaviour caused by
SSL_VERIFY_PEER
can be enabled without supplying CRL file.