Closed Maratk1n closed 5 months ago
Thank you!
I didn't test functionality yet, but compilation and tests pass.
Verified it works, thank you!
Please remove the flag.
LGTM
I've found only a small mostly cosmetic issue. Please address it and rebase on top of current master branch.
Hi @lemenkov . I've rebased branch and added unit test.
Thank you! Maybe squash all the commits at this point? I would leave only the first one as a separate commit.
No problem. I've squashed commits and rebased branch.
Thanks! Please resolve the open discussion.
Did you mean comment from github-advanced-security bot? I fixed failure but don't have permission to resolve the thread.
I meant our discussion about CMakeLists. You already resolved it :)
Did you mean comment from github-advanced-security bot? I fixed failure but don't have permission to resolve the thread.
@Maratk1n your PR raises a minimum OpenSSL version up to 1.1.0 but still there is a mention of 0.9.8 version in the doc-files. See my notes above.
Thank you @lemenkov . Fixed.
@orgads looks good to me. What's your opinion?
lgtm
Thank you!
-DUSE_SHA256=1
also to build.sh in--full
.