The original variable PCAP filenames PR #521 would free and rewrite a single per-scenario-action block of memory for every call, but all calls would continue referencing the memory. This led to various use-after-free issues. The PCAP play design also isn't set up for loading a file per call, so the solution didn't scale well.
This PR removes the variable PCAP filenames feature, while retaining the variable RTPStream filenames feature, which doesn't have the same issues.
Specific testing done:
that PCAP play is fixed
that RTPStream continues to work, with files specified as any of:
Fixes issues #576, #610, #673
The original variable PCAP filenames PR #521 would free and rewrite a single per-scenario-action block of memory for every call, but all calls would continue referencing the memory. This led to various use-after-free issues. The PCAP play design also isn't set up for loading a file per call, so the solution didn't scale well.
This PR removes the variable PCAP filenames feature, while retaining the variable RTPStream filenames feature, which doesn't have the same issues.
Specific testing done:
<exec rtp_stream="my_audio.wav"/>
<exec rtp_stream="[field0]"/>
<exec rtp_stream="[command_line_key]"/>