SIPp / sipp

The SIPp testing tool
https://sipp.readthedocs.io
Other
888 stars 375 forks source link

Remove support for variable PCAP filenames #698

Closed peter-oneill closed 3 months ago

peter-oneill commented 3 months ago

Fixes issues #576, #610, #673

The original variable PCAP filenames PR #521 would free and rewrite a single per-scenario-action block of memory for every call, but all calls would continue referencing the memory. This led to various use-after-free issues. The PCAP play design also isn't set up for loading a file per call, so the solution didn't scale well.

This PR removes the variable PCAP filenames feature, while retaining the variable RTPStream filenames feature, which doesn't have the same issues.

Specific testing done:

orgads commented 3 months ago

Thank you very much @peter-oneill!

Please add a release note.