test 0152 fails: cut: tmp.log: No such file or directory

[ryandesign]

Running regress/runtests on macOS, test 0152 fails this way:

Testing github-#0152: cut: tmp.log: No such file or directory
cut: tmp.log: No such file or directory
github-#0152/run: line 15: test: -eq: unary operator expected
failed (got  calls, and  failed)

So there are several problems:

• First, tmp.log didn't get created for some reason.
• Second, the test did not guard against that situation occurring.
• Third, a syntax error occurred because you're not quoting your variables and they happened to be empty. shellcheck points this out:

  
  In regress/github-#0152/run line 15:
  if test $calls -eq 20 && test $failed -gt 0; then
      ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                            ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: if test "$calls" -eq 20 && test "$failed" -gt 0; then

[wdoekes]

shellcheck won't help here.

If there is no tmp.log then getting values out of it is useless. Doing "" -eq 20 makes as little sense as -eq 20.

(It would've been bad if the test succeeded though.)

I wouldn't mind a fix to the script, but more relevant is why there is no tmp.log in the first place.