search

SIPp / sipp

The SIPp testing tool
https://sipp.readthedocs.io
Other
917 stars 380 forks source link

1. rtp_stream can not bind on mac. 2. \r\n in injection file #728

Closed exploman closed 4 months ago

exploman commented 4 months ago

Device information

system: macOS 14.4 (23E214) Device: MacBook Pro Apple M1 Pro 16G

Code version

master

There are two problem happened in my test.

1. rtp_stream can not bind on mac.

In trace_err log: "Could not bind port for RTP streaming after 100 tries". If I use tag v3.5.0-rc1. This problem will not happen. By searching for commit history, I found "SOCK_ADDR_SIZE" macro. By debug, if I use SOCK_ADDR_SIZE, bind will not return -1. In this merge request, https://github.com/SIPp/sipp/pull/251. I get the reason. "OSX refuse to work with an inexact (too large) addrlen." But in this merge, not fix rtp_stream. I will do it in my merge request.

2. \r\n in injection file

If \r\n is used at the end of each line in the injected file, it will result in the last field being read out as xxx\r. Such as my last field is a float: 7800.0. In debug, I found the value is 7800.0/r. And this value can not convert into float. In this commit https://github.com/SIPp/sipp/commit/131ad9dd9610bd904da5ffd9176dd314d20751e4 I found example to fix first line.

exploman commented 4 months ago

Pull request: https://github.com/SIPp/sipp/pull/729 @wdoekes