search

SISPO-developers / sispo

Space Imaging Simulator for Proximity Operations (SISPO)
18 stars 5 forks source link

Fix dependencies #223

Closed YgabrielsY closed 4 years ago

YgabrielsY commented 4 years ago

Fixes astropy unit conversion and orekit incompatibility with versions 10 and higher.

thvaisa commented 4 years ago

This is just hair-pulling, but in #222 decompose() still has irreducible units. From astropy: Generates a new Quantity with the units decomposed. Decomposed units have only irreducible units in them

Just to make it more consistent maybe convert to float because dimensionless float is still used at lines 166 and 171 both.

Otherwise looks solid.

YgabrielsY commented 4 years ago

Alright, will fix and commit

YgabrielsY commented 4 years ago

@thvaisa fixed according to comment