Feature/idf image loading

SIVICLab / sivic

SIVIC is an open-source, standards-based software framework and application suite for processing and visualizing DICOM MR Spectroscopy data. Through the use of DICOM, SIVIC aims to facilitate the application of MRS in medical imaging studies. The SIVIC code repository lives on github but our user portal is on sourceforge.

https://sourceforge.net/p/sivic/sivicwiki/Home/

Other

29 stars 14 forks source link

Feature/idf image loading #12

Closed jccrane closed 8 years ago

jccrane commented 8 years ago

This was in principle a minor change to check the series description in globbed files within svkImageReader2, however the trick was to prevent recursive calls to the method when trying to get the series description from the file list by "reading" them and in turn globbing the same file set. So this required a bit of extra work to be able to create a reader without CanRead in the ImageReader via the factory.

added test case
tests passed
note, that I haven't changed the default behavior of applications to single file loading, but the behavior should have few side effects when globbing now.

beckolson commented 8 years ago

I have made a number of inline comments in this (mostly just to test out how they work) for this PR. I think everything looks fine and can be merged but just had a couple of minor concerns:

Is the ReaderType enum necessary? It seems to me that the classname from the GetClassName would work for this.
Will this have a significant impact on the loading time for single-frame DICOM data with a large number of files such as perfusion data?

jccrane commented 8 years ago

tested performance, fixed memory leak, am going to merge this now to get ready to redeploy UCSF dev