search

SIVICLab / sivic

SIVIC is an open-source, standards-based software framework and application suite for processing and visualizing DICOM MR Spectroscopy data. Through the use of DICOM, SIVIC aims to facilitate the application of MRS in medical imaging studies. The SIVIC code repository lives on github but our user portal is on sourceforge.
https://sourceforge.net/p/sivic/sivicwiki/Home/
Other
29 stars 14 forks source link

Feature/psd prescription convert 3 plane #7

Closed stojan-m closed 8 years ago

stojan-m commented 8 years ago

psd_prescription_convert is now capable of converting DAT files to 3plane XML representation. I have added a test case for 3plane XML conversion and updated the test_data repo.

All tests passed when run on a host different from brain-vm1.

jccrane commented 8 years ago

Hi Stojan,

Sorry I didn't see the PR earlier. A couple very minor superficial points:

  1. the formatting in the block near line 356 of svkSatBandsXML.cc is indented too far. Are the changes here just indenting?
  2. add space between methods (line 426/427)
  3. lines 340-342, please add a comment to indicate why this is commented out, or perhaps better, just rm the lines and put a note in the commit on that change.
  4. just curious, what's the difference between + and - PI on line 312.
stojan-m commented 8 years ago

Thanks. I updated the sources.

jccrane commented 8 years ago

Let us know if you want the svk dev package to be redeployed for UCSF. thanks, -Jason