search

SIsilicon / WorldEdit-BE

A Minecraft Bedrock addon port of the famous WorldEdit mod for Minecraft: Java Edition.
GNU General Public License v3.0
292 stars 34 forks source link

Small typo fixes + move eslint step to lint job (CI) #231

Closed PabloAlexis611 closed 9 months ago

PabloAlexis611 commented 9 months ago

I read over the contributing guidelines - I don't think I've to do anything else.

There's an optional commit I can revert if needed at: c30b7835a0cfa793e7240f9300e87e52cd613725.

I also saw one (possible?) typo in some variables - pallete (which could be palette - unsure if that's just an English variation of the word). Also found interesting that in the src/server/modules/region_buffer.ts file there's this Block permutation state being retrieved, called attachement? 🤔 which is actually a French word and not English

SIsilicon commented 9 months ago

Huh. I've been misspelling palette the entire time

SIsilicon commented 9 months ago

And yeah I misspelled attachment too. You can go ahead and fix those typos.

PabloAlexis611 commented 9 months ago

@SIsilicon sounds good - wanted to ask first since it could've been on purpose (I've seen misspellings on purpose due to an upstream package being used that contains them so we would need to retrieve those properties with 'misspelled' words) - I can fix that shortly

PabloAlexis611 commented 9 months ago

Re-opening PR without merge conflicts

PabloAlexis611 commented 9 months ago

@SIsilicon ready for review, build failure still present (same as seen in: https://github.com/SIsilicon/WorldEdit-BE/pull/232)

(: