search

SJ001 / AI-Feynman

MIT License
638 stars 188 forks source link

final_gd signature is wrong #42

Closed lacava closed 3 years ago

lacava commented 3 years ago

final_gd takes data as argument:

https://github.com/SJ001/AI-Feynman/blob/73398ad1b739d02b4cb8d9648b208e76d0a9085d/aifeynman/S_final_gd.py#L25

but it is called with the pathdir and filename:

https://github.com/SJ001/AI-Feynman/blob/73398ad1b739d02b4cb8d9648b208e76d0a9085d/aifeynman/S_run_aifeynman.py#L300

I imagine this is not caught due to the exception handling, but that also means the final gradient descent never happens.