search

SJSU-CS-systems-group / DDD

2 stars 0 forks source link

update workflow #84

Closed gokris165 closed 3 weeks ago

breed commented 3 weeks ago

if this changed worked, the checks shouldn't be waiting right?

gokris165 commented 3 weeks ago

Nope, sorry this was just me experimenting with the workflows. I ended up creating my own repo for experimentation and found a working solution with Personal Access Tokens (PAT). The downside is that it requires the repo owner to create a PAT for their GitHub account, and then add that to this repo as a repo secret. And then we can use the PAT during our workflow to trigger the checks. I wrote about it on a thread in the discord server about very recently (my apologies on the late response).

This PR shouldn't be merged / should be closed. Here's the link to the repo with the working solution: PAT Solution

gokris165 commented 3 weeks ago

The steps to get the checks working again are somewhat explained in the repo readme but I can also fix it once you add the PAT as a secret to this repo. But I don't know if we want to go ahead with the PAT solution because maybe token security is a concern, there were a few people unhappy with this solution on the GitHub forums even though this is GitHub's recommended solution.