search

SJSURoboticsTeam / urc-central-2021

Track progress and information for the URC 2021 competition
MIT License
1 stars 0 forks source link

Remove tight coupling to Mpu6050 by using to sjsu::Accelerometer class #234

Closed naterpotatoers closed 2 years ago

kammce commented 2 years ago

What, what does this mean? Are you trying to change the MPU class itself or doing something else?

naterpotatoers commented 2 years ago

this is to resolve the tight coupling issue with the mpus. Switching the member variables to be Accelerometer object as opposed to mpu6050

kammce commented 2 years ago

Ah ok. The wording of the title is very confusing. You may want to change this to be more direct such as "Change references to Mpu6050 to sjsu::Accelerometer".

kammce commented 2 years ago

Why was this closed? Was this linked to a PR? If so list it here or make sure that you have Resolves #234 in your commit message so it automatically closes issues when the PR is merged.

Coreyboy1820 commented 2 years ago

Thanks @kammce I didn't know that was a thing. I'll do this next time. I was just trying to take care of issues that have been resolved for a few days.