SK-Yang / peepdf

Automatically exported from code.google.com/p/peepdf
GNU General Public License v3.0
0 stars 0 forks source link

PDFCore.py's search for elements/actions/events needs a space #5

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Have a PDF with /AAPL:Keywords and it will get flagged as /AA based on line 
43 of PDFCore.py .  By adding a space after each of the the items from line 
43-45, i.e. - '/AA ', you will still receive hits for legitimate Additional 
Actions still but you now won't receive false positive hits because something 
else contains _part_ of the data that was looked to match.

What is the expected output? What do you see instead?
Expected to flag only on the correct Event/Action/Element names but instead you 
may receive false hits.

What version of the product are you using? On what operating system?
Version included in REMnux - checked the latest trunk version and it should 
still be the same.

Please provide any additional information below.
pdfxray_lite also has this issue since it uses peepdf on the back end, however, 
since it uses it's own copy of PDFCore.py that owner will be contacted 
separately if this issue is accepted as it'll also need the slight change.

Original issue reported on code.google.com by hiddenil...@gmail.com on 11 Jun 2012 at 10:56

GoogleCodeExporter commented 9 years ago

Original comment by josemigu...@gmail.com on 25 Jun 2012 at 10:17

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r134.

Original comment by josemigu...@gmail.com on 2 Jul 2012 at 10:37

GoogleCodeExporter commented 9 years ago
Hi! Thanks for the feedback. I've just fixed this bug, not only adding one 
space, but checking the next character after the monitored element. The space 
solution works only with names being keys in dictionaries but in the case of 
values like /JavaScript, for example, is needed additional checks. Thanks again!

Original comment by josemigu...@gmail.com on 2 Jul 2012 at 10:41