search

SKA-ScienceDataProcessor / algorithm-reference-library

Reference code for simplified aperture synthesis imaging
Apache License 2.0
26 stars 21 forks source link

UVFITS Reader #45

Closed cnwangfeng closed 5 years ago

cnwangfeng commented 5 years ago

Hi Tim,

Thank you for the consideration to include UVFITS support in ARL.

  1. base.py: We add two functions such as create_blockvisibility_from_uvfits and create_visibility_from_uvfits. The codes have been tested strictly. Frankly speaking, the current function can't support all variations of UVFITS because it's too complex. The arguments of the functions are similar to the functions of MS file.

  2. test_visibility_uvfits: Testing codes

  3. ASKAP_example.fits : I finally upload the testing data because I found test program can't pass. Cheers,

Feng

cnwangfeng commented 5 years ago

Sry for re-committing the one file.

timcornwell commented 5 years ago

That's fine. Thanks for submitting the PR.

timcornwell commented 5 years ago

By the way, I found some indentation errors in test_visibility_uvfits. Might be your editor. I use PyCharm (Professional) since it helps avoid problems like that.

cnwangfeng commented 5 years ago

Yes. I found the errors. Shall I commit again? I am using PyCharm and Visual Studio Code alternatively.

Regards,

Feng On 26 Jan 2019, 16:30 +0000, Tim Cornwell notifications@github.com, wrote:

By the way, I found some indentation errors in test_visibility_uvfits. Might be your editor. I use PyCharm (Professional) since it helps avoid problems like that. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

timcornwell commented 5 years ago

No I fixed them.

Sent from my iPhone

On 26 Jan 2019, at 16:55, Feng Wang notifications@github.com wrote:

Yes. I found the errors. Shall I commit again? I am using PyCharm and Visual Studio Code alternatively.

Regards,

Feng On 26 Jan 2019, 16:30 +0000, Tim Cornwell notifications@github.com, wrote:

By the way, I found some indentation errors in test_visibility_uvfits. Might be your editor. I use PyCharm (Professional) since it helps avoid problems like that. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

cnwangfeng commented 5 years ago

Thanks. Have a nice weekend.

BTW, is it possible to add “**/.DS_Store” in .gitignore of master at your convenience?

Cheers,

Feng On 26 Jan 2019, 16:58 +0000, Tim Cornwell notifications@github.com, wrote:

No I fixed them.

Sent from my iPhone

On 26 Jan 2019, at 16:55, Feng Wang notifications@github.com wrote:

Yes. I found the errors. Shall I commit again? I am using PyCharm and Visual Studio Code alternatively.

Regards,

Feng On 26 Jan 2019, 16:30 +0000, Tim Cornwell notifications@github.com, wrote:

By the way, I found some indentation errors in test_visibility_uvfits. Might be your editor. I use PyCharm (Professional) since it helps avoid problems like that. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

timcornwell commented 5 years ago

Yes, I will do.

On 26 Jan 2019, at 5:08 pm, Feng Wang notifications@github.com wrote:

Thanks. Have a nice weekend.

BTW, is it possible to add “**/.DS_Store” in .gitignore of master at your convenience?

Cheers,

Feng On 26 Jan 2019, 16:58 +0000, Tim Cornwell notifications@github.com, wrote:

No I fixed them.

Sent from my iPhone

On 26 Jan 2019, at 16:55, Feng Wang notifications@github.com wrote:

Yes. I found the errors. Shall I commit again? I am using PyCharm and Visual Studio Code alternatively.

Regards,

Feng On 26 Jan 2019, 16:30 +0000, Tim Cornwell notifications@github.com, wrote:

By the way, I found some indentation errors in test_visibility_uvfits. Might be your editor. I use PyCharm (Professional) since it helps avoid problems like that. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/45#issuecomment-457847622, or mute the thread https://github.com/notifications/unsubscribe-auth/ADv3XanQ89Z6BXF2Cp2TCZQZSu3W7_d5ks5vHIurgaJpZM4aTHUC.

timcornwell commented 5 years ago

Actually I have a global ~/.gitignore_global containing: *~ .DS_Store That would be better, I think.

On 26 Jan 2019, at 5:08 pm, Feng Wang notifications@github.com wrote:

Thanks. Have a nice weekend.

BTW, is it possible to add “**/.DS_Store” in .gitignore of master at your convenience?

Cheers,

Feng On 26 Jan 2019, 16:58 +0000, Tim Cornwell notifications@github.com, wrote:

No I fixed them.

Sent from my iPhone

On 26 Jan 2019, at 16:55, Feng Wang notifications@github.com wrote:

Yes. I found the errors. Shall I commit again? I am using PyCharm and Visual Studio Code alternatively.

Regards,

Feng On 26 Jan 2019, 16:30 +0000, Tim Cornwell notifications@github.com, wrote:

By the way, I found some indentation errors in test_visibility_uvfits. Might be your editor. I use PyCharm (Professional) since it helps avoid problems like that. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/45#issuecomment-457847622, or mute the thread https://github.com/notifications/unsubscribe-auth/ADv3XanQ89Z6BXF2Cp2TCZQZSu3W7_d5ks5vHIurgaJpZM4aTHUC.

cnwangfeng commented 5 years ago

OK. But there is a .gitignore file in current ARL. It seemed this file has high priority? :)

Feng On 26 Jan 2019, 17:15 +0000, Tim Cornwell notifications@github.com, wrote:

Actually I have a global ~/.gitignore_global containing: *~ .DS_Store That would be better, I think.

On 26 Jan 2019, at 5:08 pm, Feng Wang notifications@github.com wrote:

Thanks. Have a nice weekend.

BTW, is it possible to add “**/.DS_Store” in .gitignore of master at your convenience?

Cheers,

Feng On 26 Jan 2019, 16:58 +0000, Tim Cornwell notifications@github.com, wrote:

No I fixed them.

Sent from my iPhone

On 26 Jan 2019, at 16:55, Feng Wang notifications@github.com wrote:

Yes. I found the errors. Shall I commit again? I am using PyCharm and Visual Studio Code alternatively.

Regards,

Feng On 26 Jan 2019, 16:30 +0000, Tim Cornwell notifications@github.com, wrote:

By the way, I found some indentation errors in test_visibility_uvfits. Might be your editor. I use PyCharm (Professional) since it helps avoid problems like that. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/45#issuecomment-457847622, or mute the thread https://github.com/notifications/unsubscribe-auth/ADv3XanQ89Z6BXF2Cp2TCZQZSu3W7_d5ks5vHIurgaJpZM4aTHUC.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

timcornwell commented 5 years ago

OK. It should work but it’s not worth the effort! I’ve put it in the arl .gitignore

On 26 Jan 2019, at 5:23 pm, Feng Wang notifications@github.com wrote:

OK. But there is a .gitignore file in current ARL. It seemed this file has high priority? :)

Feng On 26 Jan 2019, 17:15 +0000, Tim Cornwell notifications@github.com, wrote:

Actually I have a global ~/.gitignore_global containing: *~ .DS_Store That would be better, I think.

On 26 Jan 2019, at 5:08 pm, Feng Wang notifications@github.com wrote:

Thanks. Have a nice weekend.

BTW, is it possible to add “**/.DS_Store” in .gitignore of master at your convenience?

Cheers,

Feng On 26 Jan 2019, 16:58 +0000, Tim Cornwell notifications@github.com, wrote:

No I fixed them.

Sent from my iPhone

On 26 Jan 2019, at 16:55, Feng Wang notifications@github.com wrote:

Yes. I found the errors. Shall I commit again? I am using PyCharm and Visual Studio Code alternatively.

Regards,

Feng On 26 Jan 2019, 16:30 +0000, Tim Cornwell notifications@github.com, wrote:

By the way, I found some indentation errors in test_visibility_uvfits. Might be your editor. I use PyCharm (Professional) since it helps avoid problems like that. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/45#issuecomment-457847622, or mute the thread https://github.com/notifications/unsubscribe-auth/ADv3XanQ89Z6BXF2Cp2TCZQZSu3W7_d5ks5vHIurgaJpZM4aTHUC.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/45#issuecomment-457848815, or mute the thread https://github.com/notifications/unsubscribe-auth/ADv3XX-RVxU6yE5nDrmgW9uKaUG4fjCGks5vHI8XgaJpZM4aTHUC.