search

SKA-ScienceDataProcessor / algorithm-reference-library

Reference code for simplified aperture synthesis imaging
Apache License 2.0
26 stars 21 forks source link

Build and test tweaks #58

Closed piersharding closed 5 years ago

piersharding commented 5 years ago

HI Tim -

These are a bunch of fixes that I have for working with Python 3.7 and also some Makefile help.

Thanks, Piers.

piersharding commented 5 years ago

Sorry - I would investigate the Jenkins failure above, but I have no access to the logs.

timcornwell commented 5 years ago

Hi Piers,

Sorry about not getting to the PR. I was offline for a couple of days. The PR58 build failed because of an intermittent Dask error of a notebook. I’ve relaunched the build and will try to hunt down the cause of the Dask error.

I’ll watch for the next build.

Cheers, Tim

On 2 Jun 2019, at 6:34 pm, Piers Harding notifications@github.com wrote:

Sorry - I would investigate the Jenkins failure above, but I have no access to the logs.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/SKA-ScienceDataProcessor/algorithm-reference-library/pull/58?email_source=notifications&email_token=AA57OXKPE3YFYFL7JXIAW33PYQADJA5CNFSM4HQW4FXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWX2LAQ#issuecomment-498050434, or mute the thread https://github.com/notifications/unsubscribe-auth/AA57OXJZXROFCX7EMVZVJYLPYQADJANCNFSM4HQW4FXA.

timcornwell commented 5 years ago

Relaunched the build and it passed this time.

piersharding commented 5 years ago

Cool - thanks