Initial Healthcheck test in app ./sip/execution_control/master_contro…

[apmcd42]

…ller

Description:

There is a healthcheck funtion in the master controller folder and a test script but has been disabled for now. Would need to review it and work on it a bit to make it avaliable.

Docker compose file in deploy/demos_23_11_18 directory has been updated to run healthcheck for master_controller. It will check wether the process (PID 1) is running every 30s.

Testing instructions:

To quite bit hard to test this. You can manually check if the process is running by manually logging into the container using docker exec and then check by running "ps -opid" and see if pid 1 is running or not.

The instance to be rebuilt and tested is the execution_control/master_controller.

Types of changes

• [ ] Bug fix (non-breaking change that fixes an issue)
• [x] New feature (non-breaking change that adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [ ] The code follows the code style of this project.
• [ ] The changes require a documentation update.
• [ ] Documentation has been updated accordingly.
• [ ] Tests cover all changes in this PR.
• [ ] All new and existing tests passed.

[codecov[bot]]

Codecov Report

Merging #63 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   86.07%   86.07%           
=======================================
  Files          59       59           
  Lines        2671     2671           
  Branches      221      221           
=======================================
  Hits         2299     2299           
  Misses        321      321           
  Partials       51       51

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b29b2db...07dcf8a. Read the comment docs.

[bmort]

Unless i've completely missed something, in its current form I dont think this pull request is ready for merging into master.

Instead, It might be better to split this into a pull request to merge the health check functionality in the dockerfile and docker-compose file (which looks ready to merge) with another pull request at a later date for the updates to the Master Controller (which clearly still need some work).

For the updates to the Master Controller, while this looks like a good start, unless there are changes waiting to be committed it looks to be a fair way off being ready for merging into master. This is probably just a case of needing a bit of story & task refinement for the 2019A sprint in order for us to be able to reach a useful closeout point come the end of March.

[njthykkathu]

Hi Ben,

Sorry for getting back to you late.

This branch only has changes made to the dockerfile and docker-compose file, all the other files are disabled. There is another branch called updates/ec_mc which I am working on updating Master Controller. I haven't got a chance to finish it, just back into work yesterday. It would be a good idea to have a story/task for 2019A sprint but I am aiming to complete this very soon.

[njthykkathu]

Removed unwanted scripts from the branch.