SKA-ScienceDataProcessor / integration-prototype

SDP Integration Prototype
BSD 3-Clause "New" or "Revised" License
4 stars 7 forks source link

Updated PBC (&PC) to use the new Docker Swarm Client API (v1.0.7) #64

Closed bmort closed 5 years ago

bmort commented 5 years ago

Description:

Ready to be merged into master as soon as approved.

Testing instructions:

Start a Configuration Database (Redis) container exposing port 6379 to localhost. ie

docker service create -p 6379:6379 --name=config_db redis:5.0.1-alpine

Unit tests (unchanged by this pull request) can then be run with

./tools/run_tests.sh sip/execution_control/processing_block_controller
./tools/run_tests.sh sip/execution_control/processing_controller

Types of changes

Checklist:

codecov[bot] commented 5 years ago

Codecov Report

Merging #64 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   85.04%   85.04%           
=======================================
  Files          62       62           
  Lines        2701     2701           
  Branches      224      224           
=======================================
  Hits         2297     2297           
  Misses        353      353           
  Partials       51       51
Impacted Files Coverage Δ
...ution_control/processing_block_controller/setup.py 0% <ø> (ø) :arrow_up:
...ntrol/processing_block_controller/sip_pbc/tasks.py 88.13% <100%> (ø) :arrow_up:
...control/processing_controller/scheduler/release.py 100% <100%> (ø) :arrow_up:
...rol/processing_block_controller/sip_pbc/release.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0705d65...527b361. Read the comment docs.