Fixed PC runtime issue by removed an assert in PB for specific PBC version - Githubissues

SKA-ScienceDataProcessor / integration-prototype

SDP Integration Prototype

BSD 3-Clause "New" or "Revised" License

4 stars 7 forks source link

Fixed PC runtime issue by removed an assert in PB for specific PBC version #70

Closed bmort closed 5 years ago

bmort commented 5 years ago

Description:

Fixed an issue where the PC fails due to an incorrect PBC version assert.
- Removed assert in the PC requiring a specific PBC version. With the PBC in a state of flux while this check had good motivations it is currently causing too many problems.
Updated the PC and PBC image versions used in the demos to the latest versions to avoid any issues with incompatible interactions between the PBC and PC.

Testing instructions:

Demos can now be run according to the description i the Nov 23rd 2018 demos day slides.

Types of changes

[x] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] The code follows the code style of this project.
[ ] The changes require a documentation update.
[ ] Documentation has been updated accordingly.
[x] Tests cover all changes in this PR.
[x] All new and existing tests passed.