Bug fix: Translate 'environment' to 'env' in Docker Swarm client.

[fdulwich]

Description:

In the docker-py API, any environment variables for the service must be specified using the 'env' parameter to create(), instead of 'environment' which is used in the compose file.

Types of changes

• [x] Bug fix (non-breaking change that fixes an issue)
• [ ] New feature (non-breaking change that adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [x] The code follows the code style of this project.
• [ ] The changes require a documentation update.
• [ ] Documentation has been updated accordingly.
• [x] Tests cover all changes in this PR.
• [x] All new and existing tests passed.

[codecov[bot]]

Codecov Report

Merging #73 into master will increase coverage by 0.14%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   85.92%   86.07%   +0.14%     
==========================================
  Files          59       59              
  Lines        2671     2671              
  Branches      221      221              
==========================================
+ Hits         2295     2299       +4     
+ Misses        323      321       -2     
+ Partials       53       51       -2

Impacted Files	Coverage Δ
...control/processing_controller/scheduler/release.py	100% <100%> (ø)	:arrow_up:
...rol/processing_block_controller/sip_pbc/release.py	100% <100%> (ø)	:arrow_up:
...configuration_db/sip_config_db/_config_db_redis.py	81.77% <0%> (+1.97%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e7e292...c8da247. Read the comment docs.

[fdulwich]

Thanks Vlad, I've merged the updated master branch into this one now, so you can try again.

[vlad7235]

Unfortunately, this fix does not resolve the problem - there are still errors related to the env/environment keyword.

[fdulwich]

The new unit test suggests that this should work. I think the relevant SIP PyPI packages and containers will need to be rebuilt though, in order for this change to be picked up.