SKA-ScienceDataProcessor / integration-prototype

SDP Integration Prototype
BSD 3-Clause "New" or "Revised" License
4 stars 7 forks source link

Update EC Config db for new scheduling object data models #77

Closed bmort closed 5 years ago

bmort commented 5 years ago

Description:

This is a pre-release update to the Config DB library to support a updated workflow definition and scheduling object data models (PB/SBI) identified as as part of TSK-2710 (Prepare SIP pipelines to work automatically within SIP framework) . This also updates unit test coverage of the Config DB library to near 100% (only the low level Redis API is now missing 100% coverage). Note that this is tagged a as prerelease version as this version of the Config DB API will not currently work with the release versions of other SIP libraries and components.

Testing instructions:

Unit tests are run automatically by TravisCI but can also be run from the top level SIP repo folder with the following command:

./tools/run_tests.sh sip/execution_control/configuration_db

Types of changes

Checklist:

codecov[bot] commented 5 years ago

Codecov Report

Merging #77 into master will increase coverage by 0.77%. The diff coverage is 99.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   86.07%   86.85%   +0.77%     
==========================================
  Files          59       35      -24     
  Lines        2671     1734     -937     
  Branches      221      193      -28     
==========================================
- Hits         2299     1506     -793     
+ Misses        321      208     -113     
+ Partials       51       20      -31
Impacted Files Coverage Δ
...iguration_db/sip_config_db/states/service_state.py 100% <ø> (+14.81%) :arrow_up:
...iguration_db/sip_config_db/utils/datetime_utils.py 100% <ø> (+28.57%) :arrow_up:
...figuration_db/sip_config_db/scheduling/resource.py 100% <ø> (+10.52%) :arrow_up:
...uration_db/sip_config_db/scheduling/tests/utils.py 100% <100%> (ø)
...ip_config_db/scheduling/_scheduling_object_list.py 100% <100%> (+15.38%) :arrow_up:
...on_db/sip_config_db/scheduling/processing_block.py 100% <100%> (+4.31%) :arrow_up:
...iguration_db/sip_config_db/states/_state_object.py 100% <100%> (+16.03%) :arrow_up:
..._db/sip_config_db/scheduling/_scheduling_object.py 100% <100%> (+24.63%) :arrow_up:
.../configuration_db/sip_config_db/states/services.py 100% <100%> (+36.36%) :arrow_up:
...tion_db/sip_config_db/scheduling/workflow_stage.py 100% <100%> (+6.25%) :arrow_up:
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b29b2db...1ff17d3. Read the comment docs.