SKA-ScienceDataProcessor / integration-prototype

SDP Integration Prototype

BSD 3-Clause "New" or "Revised" License

4 stars 7 forks source link

TSK-2727 Initial Tango Log aggregator #83

Closed brianmcilwrath closed 5 years ago

brianmcilwrath commented 5 years ago

Description:

Provide an initial "Log aggregator" for the SIP Tango Device Servers - using the Master DS as an example

TSK-2727 SIP: Add aggregated Tango log messages from the SIP Tango Master device

Testing instructions:

From the top level sip repository:

Install/update the Tango SIP stack modules:

docker stack deploy - c sip/tango_control/tango_logger/docker_compose.yml sip

Bring up an iTango prompt to the current Tango stack
```
./deploy/demos_23_11_18/scripts/get_itango_prompt
```
Type the following (to the iTango prompt from (2)) to get the status of the Master Device Server
```
d=DeviceProxy('sip_sdp/elt/master')
d.status()
quit
```

examine Docker logs for Logger

docker service logs $(docker stack services -q --filter name=sip_tc_tango_logger sip)

Expect a Tango logging message from Tango_master received by Tango logger!!!!

Types of changes

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] The code follows the code style of this project.
[ ] The changes require a documentation update.
[ ] Documentation has been updated accordingly.
[ ] Tests cover all changes in this PR.
[ ] All new and existing tests passed.

codecov[bot] commented 5 years ago

Codecov Report

Merging #83 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   86.43%   86.43%           
=======================================
  Files          61       61           
  Lines        2758     2758           
  Branches      227      227           
=======================================
  Hits         2384     2384           
  Misses        322      322           
  Partials       52       52

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d8ca39...a5845c4. Read the comment docs.