search

SKCraft / Launcher

🚀 Distribute your Minecraft modpacks with a custom launcher
Other
622 stars 433 forks source link

Need help/advice (fabricloader working with skcraft) #300

Closed SDUBZ closed 3 years ago

SDUBZ commented 5 years ago

A can confimr https://github.com/SKCraft/Launcher/pull/299 is working beautifully with vanilla but cant get it to load frabric modloader it wont read installer from loader folder https://fabricmc.net/use/ even tried same methods that technic uses aswell with no luck

if anyone has any ideas how to get it to load please let me know Thanks in advanced

SDUBZ commented 5 years ago

did get this To report this error, please provide:

java.lang.NullPointerException at com.skcraft.launcher.model.minecraft.VersionManifest.getClientDownloadURL(VersionManifest.java:78) at com.skcraft.launcher.update.Updater.update(Updater.java:142) at com.skcraft.launcher.update.Updater.call(Updater.java:92) at com.skcraft.launcher.update.Updater.call(Updater.java:35) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) when adding versions.json in main modpack folder used for technic lancher

spannerman79 commented 5 years ago

Try Vanilla and download installer (universal/jar) and put it as you would with forge https://github.com/SKCraft/Launcher/wiki/Creating-Modpacks#adding-mods

NB: Haven't tried it personally but worth a shot.

SDUBZ commented 5 years ago

yeah i did it that way too no luck :(

spannerman79 commented 5 years ago

You'll need to do some changes to the launcher in order to pull the required files for 1.13+ https://github.com/SKCraft/Launcher/issues/235 Do that and try what I said https://github.com/SKCraft/Launcher/issues/300#issuecomment-493342622

SDUBZ commented 5 years ago

@spannerman79 I done both of them how do you think i got vanilla 1.14.1 loading as seen here http://puu.sh/DtoIy/b921d35ea8.png in the modpack maker to begin with also i tried alot of methods and some that most of other launchers do to get fabric working

spannerman79 commented 5 years ago

Then you'll need to setup and use a custom version manifest (by the looks of it). https://github.com/SKCraft/Launcher/wiki/Custom-Version-Manifest

SDUBZ commented 5 years ago

i do have a version manifest in modpacks root dir version.json.txt should be all correct from what i asked the fabric devs

SDUBZ commented 5 years ago

but all i get is this output To report this error, please provide:

java.lang.NullPointerException at com.skcraft.launcher.model.minecraft.VersionManifest.getClientDownloadURL(VersionManifest.java:78) at com.skcraft.launcher.update.Updater.update(Updater.java:142) at com.skcraft.launcher.update.Updater.call(Updater.java:92) at com.skcraft.launcher.update.Updater.call(Updater.java:35) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source)

SDUBZ commented 5 years ago

have to re try doing this again since fabric is more stable and on its feet 💯

LoneDev6 commented 5 years ago

I have the same problem, any news?

fabric-installer-0.5.1.36.jar did not appear to have an install_profile.json file inside -- is it actually an installer for a mod loader?

sk89q commented 5 years ago

You might be able to get the Technic bin/version.json file and put it in the installer .jar as install_profile.json, but that's a wild guess.

SDUBZ commented 5 years ago

im gonna try it and see how it goes progress but https://pastebin.com/YEFyEdg5 @sk89q

LoneDev6 commented 5 years ago

Strange, is there any official answer oever this problem?

I think I'll just endup using Forge, hoping that Forge 1.14.4 is supported by launcher

sk89q commented 5 years ago

There isn’t a standard way to install mod loaders so basically every launcher needs its own custom way to install one.

For LiteLoader and Forge they happen to just release their installers with a certain file they both include in their .jar, and it was great because it was the right amount of info the launcher needed to install them. Fabric doesn't do that.

LoneDev6 commented 5 years ago

I'll use forge then, fabric seems too "out of the standards" Thanks a lot!

Il mer 25 set 2019, 02:11 Albert Pham notifications@github.com ha scritto:

There isn’t a standard way to install mod loaders so basically every launcher needs its own custom way to install one.

For LiteLoader and Forge they happen to just release their installers with a certain file they both include in their .jar, and it was great because it was the right amount of info the launcher needed to install them. Fabric doesn't do that.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SKCraft/Launcher/issues/300?email_source=notifications&email_token=AGP24EKECL6DYJOFFNGHH73QLKUDBA5CNFSM4HNSOUZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7QFLAI#issuecomment-534795649, or mute the thread https://github.com/notifications/unsubscribe-auth/AGP24EMUKNTY2IYYAQCVYLTQLKUDBANCNFSM4HNSOUZQ .

SDUBZ commented 5 years ago

forge 1.14.4 doesnt even work with skcraft launcher ok the new problem is 1.14.4 Vanilla is not downloading its assests https://pastebin.com/5PT2YiKX @sk89q both fabric and forge

LoneDev6 commented 5 years ago

Sad I hope they'll make Fabric official compatibility a thing, since I have no time to research and implement this feature

Il sab 28 set 2019, 13:32 SDUBZ notifications@github.com ha scritto:

forge 1.14 doesnt even work with skcraft launcher

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SKCraft/Launcher/issues/300?email_source=notifications&email_token=AGP24EILJ2M66WZZMOUBMVLQL46GFA5CNFSM4HNSOUZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD72XHQA#issuecomment-536179648, or mute the thread https://github.com/notifications/unsubscribe-auth/AGP24EK5AA5ZMIPGEDKZLMTQL46GFANCNFSM4HNSOUZQ .

SDUBZ commented 5 years ago

okay lil update To report this error, please provide:

java.lang.NullPointerException at com.skcraft.launcher.builder.PackageBuilder.processLoader(PackageBuilder.java:162) at com.skcraft.launcher.builder.PackageBuilder.addLoaders(PackageBuilder.java:128) at com.skcraft.launcher.builder.PackageBuilder.main(PackageBuilder.java:392) at com.skcraft.launcher.creator.controller.task.PackBuilder.call(PackBuilder.java:66) at com.skcraft.launcher.creator.controller.task.PackBuilder.call(PackBuilder.java:21) at java.util.concurrent.FutureTask.run(Unknown Source) at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.lang.Thread.run(Unknown Source) @sk89q any ideas

mecwerks commented 4 years ago

Hello, I was able to get newest version of fabric working with some modifications on 1.15.2

Basically, I had to use the PR with 1.13+ manifest support, edit the hardcoded version_manifest url to my own custom one. This had an entry for a custom profile that i had as well that was copied from the 1.15.2 official mojang profile, but manually added in the fabric libs. Also changed the mainClass path.

I also hosted all libraries on my own webserver.

Example of version_manifest.json: https://pastebin.com/gb07gPWV Example of fabric-loader-0.7.8+build.184-1.15.2.json: https://pastebin.com/GA71fWVC

Im sure there are better ways to handle this stuff, but this worked for my own purposes.

https://github.com/SKCraft/Launcher/issues/300#issuecomment-590482950

SDUBZ commented 4 years ago

@mecwerks do you think you could write a lil guide how you did this so others could follow ?

mecwerks commented 4 years ago

I dont really plan on it, as its a very hacky way to do it. You really shouldn't need to rehost all the minecraft libraries and such. I may eventually look into making a pull request to patch it a better way.

mecwerks commented 4 years ago

Ignore my previous post. There is a far easier way to do this.

Using #270, I made an install_profile.json, and put it into a zip file. Then renamed it fabric-1.15.2+build.14-0.7.8+build.184.jar (note, the name of this jar does not matter). And put this 'fake' jar into the loaders directory and everything worked.

Example install_profile.json: https://pastebin.com/Gedn8m9T

Edit: spoke to soon, need to fix one thing, will report back shortly. Edit2: fixed and updated the install_profile.json, should work just fine with #270

SDUBZ commented 4 years ago

everything works but when it comes to the launcher it doesnt show anything new is there a step im probably missing just forgot over the years after not working with the project my urls point back and it wont read the new modpacks added lately after i made changes to the launcher 🤔 heres the url for my packages if it helps https://github.com/SDUBZ/projectlauncher/blob/level/_upload/packages.json

spannerman79 commented 3 years ago

Resolved - see latest commit

https://github.com/SKCraft/Launcher/issues/235#issuecomment-750944382

hedgehog1029 commented 3 years ago

Fabric is now supported.