search

SKCraft / Launcher

🚀 Distribute your Minecraft modpacks with a custom launcher
Other
619 stars 432 forks source link

Default Java Settings #5

Closed Sir-Will closed 10 years ago

Sir-Will commented 10 years ago

hey,

is there any way to change the default java settings?

oxguy3 commented 10 years ago

Yep, all the default configuration options are set at the top of main/com/skcraft/launcher/Configuration.java.

Sir-Will commented 10 years ago

Thanks, I will try this

Slind14 commented 10 years ago

@oxguy3 and @sk89q I changed these settings, but they don't appear in the launcher. Are they not visible but still there in the background, or did something go wrong?

oxguy3 commented 10 years ago

Are you talking about the configuration options not being accessible from the launcher? Did you click the "Options..." button at the bottom right?

sk89q commented 10 years ago

They only take effect when you first start the launcher. Afterwards, it writes the defaults as your settings.

Slind14 commented 10 years ago

not sure if we understood us right: these are the jvm args I added. https://github.com/Slind14/launcher/commit/82b05578de004142781afcdf03e715ae159a673f Now, when I build this launcher and delete everything created by the old one it doesn't show these jvm args under options: http://i.imgur.com/L2QdArz.png

sk89q commented 10 years ago

Might be a bug regarding args then