search

SKCraft / Launcher

🚀 Distribute your Minecraft modpacks with a custom launcher
Other
625 stars 437 forks source link

Neoforge really supported? #530

Open oxodao opened 2 months ago

oxodao commented 2 months ago

Hi,

I was wondering if neoforged was really supported ? I've seen this commit https://github.com/SKCraft/Launcher/commit/b5fe175650b14dac472bb84a95d15613078a84c0 but it doesn't look like it works on my end (1.21 though):

The game is running. Please wait.
Exception in thread "main" java.lang.module.ResolutionException: Modules org.apache.logging.log4j.slf4j and org.apache.logging.log4j.slf4j2.impl export package org.apache.logging.slf4j to module net.neoforged.mergetool.api
    at java.base/java.lang.module.Resolver.resolveFail(Resolver.java:900)
    at java.base/java.lang.module.Resolver.failTwoSuppliers(Resolver.java:814)
    at java.base/java.lang.module.Resolver.checkExportSuppliers(Resolver.java:735)
    at java.base/java.lang.module.Resolver.finish(Resolver.java:380)
    at java.base/java.lang.module.Configuration.<init>(Configuration.java:139)
    at java.base/java.lang.module.Configuration.resolveAndBind(Configuration.java:493)
    at java.base/java.lang.module.Configuration.resolveAndBind(Configuration.java:297)
    at cpw.mods.bootstraplauncher@2.0.2/cpw.mods.bootstraplauncher.BootstrapLauncher.run(BootstrapLauncher.java:196)
    at cpw.mods.bootstraplauncher@2.0.2/cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:69)
Process ended with code: 1

I have been using SKCraft for a long time so I don't think I'm doing something wrong though it might still be the case.

I've downloaded NeoForge from here selecting the 1.21.0 version and putting it in loaders as I've always done for Forge.

I'm running Java 21.0.3 since 17 is no longer supported on MC1.21, maybe this is related ?

hedgehog1029 commented 2 months ago

It's very possible that a new step was added to the Neoforge installer in 1.21 that the launcher doesn't implement yet - I'll have to take a look. That error implies they've started doing some Jigsaw module stuff...