SKCraft / SKMCLauncher

Deploy and distribute modpacks -- deprecated
Other
93 stars 64 forks source link

Add automatic build for Windows & MacOS version on Maven. #32

Closed Dilandau closed 12 years ago

Dilandau commented 12 years ago

I have added on pom.xml the plugins for make MacOS version & Windows version. You can see the result on my jenkins : https://build.mhonline.fr/job/skmclauncher/

md-5 commented 12 years ago

1) You broke the pom 2) There are a few reasons to not use the launch4j maven plugin 3) Launch4j can be run standalone as shown by: http://ci.md-5.net/job/SKMCLauncher/ 4) @sk89q did not want to include JavaApplicationStub since he was concerned about licensing, not sure if this is still the case.

sk89q commented 12 years ago

4) In lieu of no one giving me the license, my position is f* it, let's go!

md-5 commented 12 years ago

Since you broke this soo bad I shall manually merge it.

md-5 commented 12 years ago

Merged: http://ci.md-5.net/job/SKMCLauncher/

cmastudios commented 12 years ago

@sk89q Just noticed this pull request. I posted the license to the forum post months ago. If you still need it, it is here: http://cmastudios.me/jaslicense

md-5 commented 12 years ago

Already merged it, thanks anyway