SKCraft / SKMCLauncher

Deploy and distribute modpacks -- deprecated
Other
93 stars 64 forks source link

file not found error when zipping the /config folder. #51

Closed Jessassin closed 11 years ago

Jessassin commented 11 years ago

This error seems to be caused by uppercase characters being replaced by lowercase ones, resulting in a "file not found" error. This exists in build #56 from build.sk89q.com

image

sk89q commented 11 years ago

I think it was caused by you placing the archive in config/, and maybe config/ didn't exist in the target folder. Wish there was a stack trace.

Does the newest build fix it? http://build.sk89q.com/job/SKMCLauncher/57/

Graloth commented 11 years ago

I've tried with the latest successful build as well as the one you linked, it seems a similar error happens in both (changing letter case). It tries to access a file by it's name in all lowercase, though it's only available with the capital letters.

Downloading http://arduard.com/hardmode/config/unlittorch.cfg... Downloading to C:\Users*****\AppData\Roaming.minecraft\instances\arduard.com_arduard-hardmode.minecraft_download_4ce64c6fbfa643440e97aea4da758b57.download... Failed to download http://arduard.com/hardmode/config/unlittorch.cfg

The correct path to the config is http://arduard.com/hardmode/config/UnlitTorch.cfg

Any help would be greatly appreciated, as I would like to use your launcher to distribute a modpack amongst friends but this error is preventing the "install from URL" as well as the update functionality from working as intended

UPDATE

Looked some more into it, and found out that the package.xml that the launcher generates when you want to make your own install for a modpack etc. it converts all foldernames and filenames in /config to lowercase, except it doesn't do it for the files themselves, only their reference

sk89q commented 11 years ago

Is it possible to give me a bare minimum set of files that break?

jakimfett commented 11 years ago

A note on this: If you build the pack via the GUI, and de-select the zip configs option, the file paths in package.xml are NOT converted to lowercase, and they have "" tags instead of "" tags. See http://picraft.com/pitek/package.xml vs http://mc.picraft.com/bleeding/package.xml

sk89q commented 11 years ago

Fixed now, I believe.

56 has reason